Email attachment - opening attachment display "inode error"

dcaliste · 6 January 2022 14:27

I’m proposing a fix for this bug, see:

github.com/sailfishos/nemo-qml-plugin-email

[nemo-qml-plugin-email] Don't set URL in attachment list model if the…

sailfishos:master ← dcaliste:inode

opened 02:26PM - 06 Jan 22 UTC

dcaliste

+10 -8

… file does not exist. @pvuorela, I'm trying to solve https://forum.sailfisho…s.org/t/email-attachment-opening-attachment-display-inode-error/4805/6 The reproducer is the following: - use POP - get an email with at least two attached files - tap on the first one : it is opened - tap on the second, a banner will complain about the impossibility to open inode mime type and bug path is: - in attachmentlistmodel, after the first file has been copied from QMF internal storage to the file structure in Download, the `QFileSystemWatcher` callback line 298 in triggered. But for other attachment, the files have not been copied yet. So `attachmentPath()` is return an empty string, - then `onAttachmentPathChanged()` is creating an URL with just the directory. I think the `onAttachmentPathChanged()` should not mangle the path. It is called from the email agent that is getting the path from QMF only and thus guaranteed to be valid. The fact that we are using this callback by hand in the file watcher with a wrong path is the problem. The PR here is fixing the problem, but I would consider two better possibilities for medium term : - get the filename for a part directly from QMF instead of mimicking its behaviour with `.remove('/')` statements, - remove the directory watcher completely, since the email agent will signal anyway when a file has been downloaded and copied to a valid URL.