@dcaliste has a different patch for that, too, higher up in this thread:
I think itās a good idea. It would be great to get such a patch reviewed and merged (if accepted) upstream. It would improve consistency a lot, as much as using pulleyā¦
First and most simple version, against upstream/next
rev 0e401c5f
. Sorry for posting this here, I canāt be bothered to make a PR just for 15 lines of color changes
diff --git a/apps/browser/qml/pages/components/PopUpMenu.qml b/apps/browser/qml/pages/components/PopUpMenu.qml
index 814b9900..9e446962 100644
--- a/apps/browser/qml/pages/components/PopUpMenu.qml
+++ b/apps/browser/qml/pages/components/PopUpMenu.qml
@@ -141,9 +141,9 @@ SilicaControl {
width: footerLoader.width
height: footerLoader.y - y
- color: Qt.tint(
- popUpMenu.palette.colorScheme === Theme.LightOnDark ? "black" : "white",
- Theme.rgba(popUpMenu.palette.primaryColor, Theme.opacityFaint))
+ color: Qt.rgba(
+ Theme.highlightDimmerFromColor(Theme.highlightBackgroundColor, Theme.colorScheme),
+ Theme.opacityFaint)
},
Item {
id: decoratorParent
diff --git a/apps/browser/qml/pages/components/PopUpMenuFooter.qml b/apps/browser/qml/pages/components/PopUpMenuFooter.qml
index 7dbdd65c..3f2648bd 100644
--- a/apps/browser/qml/pages/components/PopUpMenuFooter.qml
+++ b/apps/browser/qml/pages/components/PopUpMenuFooter.qml
@@ -17,9 +17,9 @@ Rectangle {
height: Theme.itemSizeMedium - Theme.paddingMedium
implicitWidth: content.width
- color: Qt.tint(
- Theme.colorScheme === Theme.LightOnDark ? "black" : "white",
- Theme.rgba(Theme.primaryColor, root.overlayOpacity))
+ color: Qt.rgba(
+ Theme.highlightDimmerFromColor(Theme.highlightBackgroundColor, Theme.colorScheme),
+ root.overlayOpacity)
Row {
id: content
diff --git a/apps/browser/qml/pages/components/TabItem.qml b/apps/browser/qml/pages/components/TabItem.qml
index 8f475995..a72e92e4 100644
--- a/apps/browser/qml/pages/components/TabItem.qml
+++ b/apps/browser/qml/pages/components/TabItem.qml
@@ -57,7 +57,7 @@ BackgroundItem {
Rectangle {
anchors.fill: parent
- color: Theme.colorScheme === Theme.LightOnDark ? "black" : "white"
+ color: Theme.highlightDimmerFromColor(Theme.highlightBackgroundColor, Theme.colorScheme)
ColorOverlay {
anchors.fill: parent
diff --git a/apps/browser/qml/pages/components/TabsToolBar.qml b/apps/browser/qml/pages/components/TabsToolBar.qml
index ce1c6fcc..ec71c80b 100644
--- a/apps/browser/qml/pages/components/TabsToolBar.qml
+++ b/apps/browser/qml/pages/components/TabsToolBar.qml
@@ -33,7 +33,7 @@ Item {
Rectangle {
anchors.fill: parent
- color: Theme.colorScheme == Theme.LightOnDark ? "black" : "white"
+ color: Theme.highlightDimmerFromColor(Theme.highlightBackgroundColor, Theme.colorScheme)
}
So, selecting Theme.highlightDimmerFromColor(Theme.highlightBackgroundColor
was more or less a random choice for the background color base, but it certaily is better than defaulting to black/white.
Soooooo, 4.4.0 should have a close button again. https://github.com/sailfishos/sailfish-browser/pull/905
Feel free to bikeshed, if the overlay should close or not after closing a tab :3
Thanks goes to https://github.com/deepbluev7 to drive āclose buttonā through. I just merged it.
Finally some closure! (Btw, deepbluev7 is me, I just chose a different username for some reason :3)
Great work!
I love the Qt6 snaps in there .
First I created this post in #bug-reports then I thought about #design at last i saw this thread
Ttile: Menu on top of default text in browser. papercut / minor issue
REPRODUCIBILITY: Always
OS VERSION: 4.4
HARDWARE: Xperia X / 10 III
UI LANGUAGE: Norwegian
REGRESSION: ?
DESCRIPTION:
Minor cosmetic issue with the menu overlapping text in the browser.
(May be best to remove help text)
PRECONDITIONS:
Have bookmarks in the browser
STEPS TO REPRODUCE:
- Type in the name of a bookmark
- Remove all remembered sites in history that have the same name as your bookmark
- Tap and hold the bookmark
EXPECTED RESULT:
Favicon does not get thrown halfway into the void and the menu do not overlap āWebsites you visit will be shown hereā
ACTUAL RESULT:
Menu overlays text in portrait mode, but not in landscape.
MODIFICATIONS:
None.
ADDITIONAL INFORMATION:
Images from Xperia X
From Xperia 10 III
Hmm, maybe this to snuck in in the 4.2 update (because thatās what you are saying by posting here?) and wasnāt noticed because of the bigger issues. It sure isnāt pretty, although it looks like two intentional design choices colliding.