Patches by ichthyosaurus

Can confirm this for 5.0 as well, same hunk failure.

@ichthyosaurus I think itā€™s because of this:

Maybe move the y: stuff below the PropertyChanges, so it avoids the collision with the missing/added width: popper.expandedWidth line.

5 Likes

Thank you for your help, @eson and @nephros! I just published v1.5.2 with support for SFOS 4.5 and 4.6. Maybe itā€™s also compatible with 5.0 but I canā€™t test that.

The problem was actually caused by just three blank lines that Jolla added recently. Itā€™s such a shame that the Jollaā€™s keyboard plugin and Silica arenā€™t open sourceā€¦

2 Likes

hmmā€¦ that one killed maliit completely dead on SFOS 4.6, for me. :wink:

Thatā€¦ should definitely not happen :upside_down_face:

First, try restarting the phone to make sure Patchmanager is in a clean state, and try applying the patch again. Is there any output in Patchmanager?

If it still doesnā€™t work, can you send me the output of devel-su journalctl -r after applying the patch and restarting maliit?

Hereā€™s some Patchmanager outputā€¦

Summary

pm_apply 2024-11-10T14:30:25+01:00

sfos-patch-keyboard-color-stock-emojis

Using patch file: /usr/share/patchmanager/patches/sfos-patch-keyboard-color-stock-emojis/unified_diff.patch


Test if already applied patch

The next patch, when reversed, would delete the file usr/lib/qt5/qml/com/jolla/keyboard/ichthyo_color_emojis/EmojiSearch.qml,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/lib/qt5/qml/com/jolla/keyboard/ichthyo_color_emojis/qmldir,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
checking file usr/share/maliit/plugins/com/jolla/HorizontalPredictionListView.qml
Unreversed patch detected! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
5 out of 5 hunks ignored
checking file usr/share/maliit/plugins/com/jolla/PasteInputHandler.qml
Unreversed patch detected! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
3 out of 3 hunks ignored
checking file usr/share/maliit/plugins/com/jolla/Popper.qml
Unreversed patch detected! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
10 out of 10 hunks ignored
checking file usr/share/maliit/plugins/com/jolla/PopperCell.qml
Unreversed patch detected! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
3 out of 3 hunks ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiConfig.qml,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiConfigLabel.qml,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiConfigOverlay.qml,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiGroupKey.qml,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiKey.qml,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiPlaceholder.qml,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/KeyboardRestarter.qml,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji.js,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data.js,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_de.js,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_es.js,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_fr.js,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_nb.js,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_sv.js,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/qmldir,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
checking file usr/share/maliit/plugins/com/jolla/layouts/emojis.qml
Unreversed patch detected! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
checking file usr/share/maliit/plugins/com/jolla/layouts/layouts_emojis.conf
Unreversed patch detected! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored


Dry running patch file

checking file usr/lib/qt5/qml/com/jolla/keyboard/ichthyo_color_emojis/EmojiSearch.qml
checking file usr/lib/qt5/qml/com/jolla/keyboard/ichthyo_color_emojis/qmldir
checking file usr/share/maliit/plugins/com/jolla/HorizontalPredictionListView.qml
checking file usr/share/maliit/plugins/com/jolla/PasteInputHandler.qml
checking file usr/share/maliit/plugins/com/jolla/Popper.qml
checking file usr/share/maliit/plugins/com/jolla/PopperCell.qml
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiConfig.qml
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiConfigLabel.qml
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiConfigOverlay.qml
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiGroupKey.qml
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiKey.qml
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiPlaceholder.qml
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/KeyboardRestarter.qml
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji.js
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data.js
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_de.js
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_es.js
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_fr.js
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_nb.js
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_sv.js
checking file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/qmldir
checking file usr/share/maliit/plugins/com/jolla/layouts/emojis.qml
checking file usr/share/maliit/plugins/com/jolla/layouts/layouts_emojis.conf


Applying patch file

patching file usr/lib/qt5/qml/com/jolla/keyboard/ichthyo_color_emojis/EmojiSearch.qml
patching file usr/lib/qt5/qml/com/jolla/keyboard/ichthyo_color_emojis/qmldir
patching file usr/share/maliit/plugins/com/jolla/HorizontalPredictionListView.qml
patching file usr/share/maliit/plugins/com/jolla/PasteInputHandler.qml
patching file usr/share/maliit/plugins/com/jolla/Popper.qml
patching file usr/share/maliit/plugins/com/jolla/PopperCell.qml
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiConfig.qml
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiConfigLabel.qml
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiConfigOverlay.qml
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiGroupKey.qml
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiKey.qml
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/EmojiPlaceholder.qml
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/KeyboardRestarter.qml
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji.js
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data.js
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_de.js
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_es.js
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_fr.js
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_nb.js
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/emoji_data_sv.js
patching file usr/share/maliit/plugins/com/jolla/ichthyo_color_emojis/qmldir
patching file usr/share/maliit/plugins/com/jolla/layouts/emojis.qml
patching file usr/share/maliit/plugins/com/jolla/layouts/layouts_emojis.conf


Creating backup of patch file

Created backup: /tmp/patchmanager3/patches/sfos-patch-keyboard-color-stock-emojis

*** SUCCESS ***

Nothing helps though, so Iā€™ll dig out some journalctl.

2 Likes
Nov 10 16:00:04 PGJollaC2 [16732]: [W] unknown:0 - bool MIMPluginManagerPrivate::loadPlugin(const QDir&, const QString&) Error loading plugin from "/usr/lib64/maliit/plugins/libmaliit-keyboard-plugin.so" "The shared library was not found."
Nov 10 16:00:04 PGJollaC2 [16732]: [D] unknown:0 - Using Wayland-EGL
Nov 10 16:00:05 PGJollaC2 [16732]: [W] unknown:509 - file:///usr/lib64/maliit/plugins/jolla-keyboard.qml:509:9: Type PasteInputHandler unavailable
                                                PasteInputHandler {
                                                ^
Nov 10 16:00:05 PGJollaC2 [16732]: [W] unknown:7 - file:///usr/share/maliit/plugins/com/jolla/PasteInputHandler.qml:7:1: module "com.jolla.keyboard.ichthyo_color_emojis" is not installed
                                        import com.jolla.keyboard.ichthyo_color_emojis 1.0
                                        ^
^C

Buut!

/usr/lib/qt5/qml/com/jolla/keyboard/ichthyo_color_emojis/EmojiSearch.qml does exist. It really shouldnĀ“t because that is the wrong path.

Soo that may actually an issue with PatchManagerā€™s 64bit handling. Iā€™ll have to check that.

Be right back!

4 Likes

@eson, can you check whether the 32/64 bit conversion is enabled in your PatchManager Settings?

1 Like

No, itā€™s not. Ā 

1 Like

OK, can you please:

  1. Unapply/deactivate the patch
  2. Restart Preloaded Services from PM (restarts maliit-server)
  3. Toggle the switch on ON
  4. Activate the patch
  5. Restart Preloaded Services from PM (restarts maliit-server)

and then try again?

1 Like

I just checked, enabling or disabling the 32/64 bit conversion doesnā€™t seem to change anything, as long as the patch is applied, the keyboard doesnā€™t work at all.

1 Like

Yes, for some reason the mangling code does change the patch, but it still applies the 32bit version.

On it! :slight_smile:

4 Likes

Still no keyboard, as nthn already said.

3 Likes

Keyboard patch installed correctly, still when I try to run the emoji-dl.sh script via SSH, I get the following:

[root@XperiaXA2 Downloads]# ./emoji-dl.sh apple
./emoji-dl.sh: line 26: shopt: not found
./emoji-dl.sh: line 28: syntax error: unexpected ā€œ(ā€

4 Likes

Then we found the issue, thank you for investigating! :bouquet: I only had the opportunity to test it on a 32bit phone.

So: everyone with a 64bit phone has to wait until @nephros can release a fix in patchmanager, or you can edit the patch file to say /usr/lib64/qt5 instead of /usr/lib/qt5. People using 32bit phones should be able to update the emoji patch without issues.

You must run this on a computer, not on your phone. The script requires bash, and can be quite resource intensive. Just copy the downloaded and post-processed files to your phone after running the script.

Also: make sure you have the most recent version of emoji-dl.sh. I updated it yesterday because the source API has changed.

6 Likes

Very well!
On XA2 itā€™s now working flawlessly. :upside_down_face:

Thank U!

3 Likes

Where is the patchfile located? Iā€™ve also tried to get the emoji keyboard to run but ends up with the same issue at my 64bit device.

The file is: /usr/share/patchmanager/patches/sfos-patch-keyboard-color-stock-emojis/unified_diff.patch

@nephros already found and fixed the issue in patchmanager, though

3 Likes

Thank you for the fast answer. I have to replace all /usr/lib/qt5 entries inside the file?

I use the patchmanager provided by Chum. But this version is from December 2023.

Now it works. I changed all entries related to /usr/lib/qt5 and now I can see the OpenMoji at the keyboard. Thanks again for this stunning piece of patch.

1 Like

ā€¦ but that fix is not yet released. Itā€™s going to be ā€œSoonā„¢ā€.

6 Likes