[4.1.0.23][10 II] Documents/sailfish-office can't open odt/doc(x)/ [FIXED]

Bug Reports
#1

REPRODUCIBILITY (% or how often): 100%
BUILD ID = OS VERSION (Settings > About product): 4.1.0.23
HARDWARE (XA2, Xperia 10…): 10 II
UI LANGUAGE: Swedish
REGRESSION: (compared to previous public release: Yes, No, ?): Yes?

DESCRIPTION:

Can’t open odt/doc(x) and other “office” formats in sailfish-office.
Seems Calligra doesn’t load.

PRECONDITIONS:

none

STEPS TO REPRODUCE:

  1. Open Documents app
  2. Try to open a odt document

EXPECTED RESULT:

Document opens

ACTUAL RESULT:

Error page with (roughly) “could not load page”.

ADDITIONAL INFORMATION:

I had been experimenting with Calligra, but confirmed by @orangecat here

#2

Found the problem:

It is here (should be lib64 conditionally).
…aka here on the version before dcaliste’s uplift, which is actually what we get in 4.1.

(Tested with local rebuild, but from latest)

ping: @pvuorela

#3

Figured out how to do it properly:

-+set(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib/calligra-kf5")
++set(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}/calligra-kf5")

@dcaliste But i guess making a MR directly modifying the patch is frowned upon? :slight_smile:

#4

No actually that’s the way to go. Good catch. Sorry that it was not spotted before… I don’t have a aarch64 device myself.

Do you want to do the MR ? The way I do it usually is like that:

  • checkout the version that is in 4.1.0.23 locally,
  • go to the upstream directory,
  • apply all patch there with for i in ../rpm/00*.patch ; do git am $i; done or something equivalent,
  • do your modification and commit it,
  • squash it with the commit it is modifying,
  • regenerate all patch with `git format-patch -N sha-of-last-commit-in-4-1-0,
  • move the patches to …/rpm/,
  • go back to root of your calligra directory, view with a git diff rpm that you didn’t make to many changes ;^)
  • commit your modification in rpm/, push it and create a merge request.

It looks long like that, but it’s quite simple actually. Of course, you can patch the patch by hand. It should give the same result. Just that I find the long road a bit safer.

2 Likes
#5

Well, i meant hand-modifying the literal patch. :slight_smile:
So from your explanation, i read it as a “no”. I have started down this path, so i might just as well continue and figure out how to get rid of the last bits of unnecessary diff.

Thanks for chiming in.

Edit: pushed.

1 Like
#6

Fixed in 4.1.0.24  

2 Likes