3.4.0.22 UI inconsistences in email client

Design
#43

I found a way to bring back the pulley menu in emails.

THERE IS NO GARANTY THAT IT WON’T BREAK ANYTHING ! Use at your own risk

Edit /usr/share/jolla-email/pages/HtmlViewer.qml Add the following above the “MessageViewFooter” block:

    MessageViewPullDown {
        id: pulley
    }

After that, restart the email application. I don’t know yet how to remove the buttons.

10 Likes
#44

@wgs

hidden buttons;

    MessageViewFooter {
        id: footer
        visible: false    < --------added here.

        x: landscapeInviteContainer.width
        // Don't move with the keyboard.

Not perfect, but does the job.

10 Likes
#45

@wgs - Hi, i’m curious as to how you discovered the 2 lines of code to bring back the pulley menu?, very cool indeed.

My immediate approach was simply to add the whole pulley menu back, but your code does it in just 2 lines…how?, where?, why? :D…tell me more!

#46

I discovered it by accident really.

I started from your solution to change the footer background color by editing MessageViewFooter.qml. In the folder /usr/share/jolla-email/pages I grep'd "MessageViewFooter, to see what comes up, and found that it’s used as a class in HtmlViewer.qml. I also noticed a file named MessageViewPullDown.qml, which I figured was the class for the pulley menu, rather than footer buttons. As it was not referenced anywhere else, I figured I would just add an empty block to see what happened. That’s all really :slight_smile:.

To be honest, I have no idea why it works haha !

8 Likes
#47

Aaah, that’s much better. Thanks @wgs!

#48

There were a couple UI related topics in today’s community meeting:

Consistency of SFOS UX/UI across apps
UI

1 Like
#49

Pulley Menu & Buttons are now patched:

Openrepos

https://openrepos.net/content/markkyboy/patch-returns-pulley-menu-email-view

Or, direct download;

https://openrepos.net/sites/default/files/packages/1290/sailfishos-patch-email-pulley-menu-0.1-3.noarch.rpm

7 Likes
#50

In the latest meeting the subject was touched and jolla devs mentioned it was a change dictated by the new engine used in the email client. And that it would be difficult to patch and that it would create problems.

No idea what is going on with this. :no_mouth:

1 Like
#51

Maybe it was due to this? :smiley:

@edz
how hard was it and did you encounter any problems yet?

#52

Sledges also mentioned in the community meeting that text selection within emails might conflict with pull-down. Might be a good idea to check.

If a good fix is found, it would be a good idea to raise this issue again in next community meeting.

1 Like
#53

@peterleinchen says: How hard was it?
Me: Not hard at all, then made even easier with wgs’s slimline code.

@peterleinchen says: did you encounter any problems yet?
Me: Not as yet, but then i don’t rely on the email client, I use my PC for that.

@Sefriol says: text selection within emails might conflict with pull-down. Might be a good idea to check.
Me: I’ve just checked with both plain and HTML mail, I can copy (and paste contents into a text message, reliably) and pull down the menu. The selected text stays selected while the pulley menu is pulled down completely and clipboard does honour what was copied.
So far, so good.

UPDATE 19/10/2020
Well, one user already spotted a problem with my patch, deleting the mail when in mail view doesn’t delete the mail, so I returned to my original patch contents which fixes this problem in version 0.1-2
Please use version 0.1-2

5 Likes
#54

Some more insight by jpetrell: About redesigning incoming call experience in 3.4.0

#55

To reduce the duration of the white flash a little bit when opening an email, I modified line 193 in:
/usr/lib/qt5/qml/Sailfish/WebView/WebView.qml
from “color: webview.bgcolor” to "color: “transparent”.

As far as I know, the css file for manipulating html pages can now be found under
/usr/share/jolla-email/chrome/content/content.css.
But the main problem remains that the browser or webview always opens a page with a white background first.
Unfortunately, with my limited abilities, I can’t get any further.

#56

I think maybe, just maybe, the white background is baked into libsailfishwebviewplugin.so (I may have that file name a slightly wrong).

Also, the part of the file you edited it just for transition between portrait and landscape and so won’t affect the white background, hence the id: orientationDelayOverlay - I could be wrong.

#57

Please bring back old UI.

4 Likes
#58

I also first noticed the white background in plain text email after the last release :thinking:

Problems plaguing Sailfish OS for too long
#59

Are you planning to make the patch available in Patchmanager3? Or should I?

#60

I don’t understand?, it already works in/under Patchmanager 3, unless you are referring to Patchmanager’s WebCatalog, in which case, no, you can do what you like with the patch/contents :slight_smile:

#61

Yes, I was refering to WebCatalog. And didn’t check what the patch does :flushed:. So better that I don’t put an another way to install the same patch to patchmanager.

#62

Nice trick, thank tou.
However, here, it does hide “Share”, “Select all” and “Clear” buttons that appear when text is selected.