WebView produces incorrect screen.height, window.innerHeight values

flypig · 1 December 2022 14:02

Excellent! Since you have preference files that don’t include the value, it may be that there are committed but unreleased changes to this in the pipeline. Let me see if I can find the place where this is set, as I suspect this may be useful for figuring out what should be happening on the Volla.

poetaster · 1 December 2022 14:04

Thanks! Not sure if you covered it in your webview article(s) but are the user prefs settable from within QML?

flypig · 1 December 2022 14:06

I’m not sure whether I covered it either but it can be, yes, see pixelRatio here:

flypig · 1 December 2022 14:16

It looks like the code to determine the default pixel density can be found at the link below.

It could be that these values don’t work well for the Volla, although I’m not sure why there would be a difference between the browser and the WebView I’m afraid.

Once you’ve experimented with values on the Volla, it would be good to know what you conclude.

github.com

sailfishos/sailfish-components-webview/blob/8c0fefae1ba56ed351a570341df48e91d974928b/lib/webenginesettings.cpp#L178

      
        
            // Do not floor the pixel ratio if the pixel ratio less than 2.0 (1.5 is minimum).
            if (pixelRatio >= 2.0 && !testScreenDimensions(pixelRatio)) {
                qreal tempPixelRatio = qFloor(pixelRatio);
                if (testScreenDimensions(tempPixelRatio)) {
                    pixelRatio = tempPixelRatio;
                }
            } else if (screenWidth >= 1080) {
                pixelRatio = qRound(pixelRatio);
            }
            
            
engineSettings->setPixelRatio(pixelRatio);
            
            
int tileSize = screenWidth;
            
            
// With bigger than FullHD screen fill with two tiles in row (portrait).
            // Landscape will be filled with same tile size.
            if (screenWidth > 1080) {
                tileSize = screenWidth / 2;
            }
            engineSettings->setTileSize(QSize(tileSize, tileSize));

poetaster · 1 December 2022 14:31

Using the WebEngineSettings.pixelRatio = 3 works fine on volla/gs290 and gs5 phones. Looks like a universal. Ok, so I can implement soft fixes for all my apps. Thanks!