Tidal App discussion

i can see 2 items in ‘for you’. recently played section is empty
at quick glance all my changes are there
play album menu is nice :slight_smile:

added a small change myself to fav buttons …

the buttons in settings do all work too, only the quality gets reset to 320, but that was there already before.

thank you for the update !

For me to do chum properly, I need to do tags and or releases. So, I’d ask you to push your changes often, and when you feel you’re at a stable point (ha!) make a tag and push it. I usually do semver + a letter … so 0.4.1 (minor update to 0.4) and I add a letter v0.4.1 if it’s proper. That causes github to automatically build (the letter in front).

I’ll set it up in my clone, but I can’t know what stage you guys are at if I don’t see commits and especially some tags. Thanks for going on this!

EDIT: I just noticed that your existing action builds on pushes to master. Could do, but doesn’t that get noisy? I use push to tags with a regex to keep builds to only really ready to build so:

on:
  push:
    tags:
      - 'v*'

committing now …

Should i see something already ?
Did check testing repo too

It’s here: Show home:poetaster / harbour-tidalplayer - SailfishOS Open Build Service … still waiting to get into chum testing. whereafter I shall, errr, test it?

Edit: the changes I’ve made so far are small but, maybe someone wants to have a look: Comparing conradhuebler:master...poetaster:master · conradhuebler/harbour-tidalplayer · GitHub

1 Like

I will have a look later or tomtomorrow …

1 Like

did download and install app. seems to work fine

found bugs:

  1. play playlist button on home, will not clean old playlist, so rather append then replace and play (play album works correctly)
  2. play track is broken too.
1 Like

The code this is based on it a bit older, I think. So, that’s why you guys need to push to the repo :slight_smile:

EDIT, well, there was a push 2 days ago, so maybe it’s not older? I’ll test tomorrow and then proceed.

no the errors do reflect the current stage :slight_smile:
play track is fixed.
play playlist works locally for me …

Thank you !
Missed that :slight_smile:

Merged pull request and put the correct icons in place. With the relevant changes for chum, I would say the first tag on github will came close :slight_smile: thanks for your support and feedback.

1 Like

Ah, ok, so you pulled my changes? I hadn’t issued a merge request so I’m a bit lost. Probably best if I point the cum repo to your github repository when it’s in testing. EDIT, ok, no. I just made a pull request and I’ll try to get everything clean mergeable.

EDIT 2, and @piggz pushed into chum testing. Once my changes are merged, I’ll change the chum testing repo to point to @contra 's github once tags are in use. Till then, I’ll sync and follow along.

1 Like

I have merged your changes, did small adoptions and tagged a first version. I hope this fits so far :slight_smile:

1 Like

Cool! I’ll look at chum testing tomorrow and hopefully start building against your repository. That should make it fairly quick an painless to publish to chum.

1 Like

have implemented ‘play-artist’ on personal and artist page.

what nerves is that the player closes on some interaction, not sure why.
beside that, feature wise i do not need much more

When i did switch to testing repo, i saw a higher version of one of my apps.
Can you please remind me how to push it to normal ?

Ich you were using the chum app, just go to settings and turn of the ‘testing’ repository option

I wonder how i can push the version from testing to productive.
The app in obs i mean

Thanks a lot for you contribution :slight_smile: it is a great support. I merged your changes, will play around a bit with the app and make a new tag next week

Is tidal app from chum considered working version for users?
If yes then tidal login via webview doesn’t work for me. It opens sailfishos.org page only. I believe that you are using manually set tokens and missed that issue.

I havent tested the version from chum, but only the versions from github actions. Since SFOS 4.5 browser doesnt work an gh, I can not poste the link till sunday …

If the gh version doesnt work too, I have to investigate, with logs from the console …