Javascript Error with Form Inputs sailfish-browser and WebView

poetaster · 22 November 2021 09:52

REPRODUCIBILITY (% or how often): 100
BUILD ID = OS VERSION (Settings > About product): 4.3.0.12
HARDWARE (XA2, X10, X10 II, …): vollaphone/gigaset GS290
UI LANGUAGE: English
REGRESSION: (compared to previous public release: Yes, No, ?): Yes.

DESCRIPTION:

When putting the focus on Form elements in pages:

JavaScript error: chrome://embedlite/content/FormAssistant.js, line 253: TypeError: form is null

Repeats as often as you enter chars.

PRECONDITIONS:

STEPS TO REPRODUCE:

Start Browser or WebView app (with form inputs)
Tap on a Form text input.

EXPECTED RESULT:

Smooth interaction with Form inputs. No errors?

ACTUAL RESULT:

The Text inputs do ‘take’ but they are very sluggish.

ADDITIONAL INFORMATION:

I was debugging the performance of text input in a WebView wrapper (github.com/poetaster/harbour-scanner) AND also responding to a ticket about performance degrading in the browser.

In the 3.4 browser (obviously not WebView) this does not happen.

nephros · 22 November 2021 13:31

So, that one:

github.com

sailfishos/embedlite-components/blob/1.23.11/jsscripts/FormAssistant.js#L253

    
      
                // bug 159484 - disallow url types that don't support a hostPort.
                // (although we handle "javascript:..." as a special case above.)
                log("Couldn't parse origin for", uriString, e);
                realm = null;
              }
          
          
    return realm;
            },
          
          
  _getActionOrigin(form) {
              var uriString = form.action;
          
          
    // A blank or missing action submits to where it came from.
              if (uriString == "")
                uriString = form.baseURI; // ala bug 297761
          
          
    return this._getPasswordOrigin(uriString, true);
            },
          };
          
          
function FormAssistant() {

Looks like that is fixed in master:

github.com

sailfishos/embedlite-components/blob/master/jsscripts/FormAssistant.js#L254

    
      
              realm = null;
            }
          
          
  return realm;
          },
          
          
_getActionOrigin(element) {
            let form = element.form;
            let formAction = element.formAction;
            var uriString = "";
            if (form && form.action) {
              uriString = form.action
            } else if (formAction) {
              uriString = formAction;
            }
          
          
  // A blank or missing action submits to where it came from.
            if (uriString == "")
              uriString = form.baseURI; // ala bug 297761
          
          
  return this._getPasswordOrigin(uriString, true);

via

poetaster · 22 November 2021 14:09

Now to push it to a device OH:
/usr/lib64/mozembedlite/chrome/embedlite/content/FormAssistant.js
Don’t hack this at home, kids.

poetaster · 22 November 2021 14:20

Ok, hacking in /usr/lib64 does not work :< Probably better that way:)

EDIT: open remains the question why it repeats on repeated characters being entered into the same field. That function should only fire on FOCUS if I understand the FormAssistant.

Maybe that’s the gist of the performance issue. If the form is being repeatedly checked with dom methods to determine if it’s a password user field? Hmmmm. Ouch.