App of Matrix-client Hydrogen up for adoption

General
#3

Great! Now that I am starting to use matrix some more, hydrogen needs/gets some help.
BTW, the latest changelog Releases · vector-im/hydrogen-web · GitHub adds voice/video… no pressure:)

2 Likes
#4

@thigg you also have this app in the Jolla Store. I assume you will continue to do that?

One curiosity: where is specify command from in your build.sh? I don’t have it on my (non-rpm-based) linux distro and can’t seem to find its package - not very duckduck go friendly:)
It built for me with sfdk build without that command.

#5

I think the build.sh script was intended for the build on OBS. sfdk build is certainly the right way.

What do you mean?

#6

Well, I actually know close to nothing about Jolla app store submission process. Can that be transferred? Would removing it and adding another one with the same name generate updates for existing users?
That would be my blind spot.

#7

I think you can ask the support to transfer ownership

#8

Thanks for the answers.

So last night I forked hydrogen-web too and used 3.7.1 + squashed the PR that introduces back navigation - as pointed in your PR adding back navigation to their repo. Thanks for that!
I also updated the submodule in my ‘forked’ harbour-hydrogen (I took the chance to rename the repo) and even built it on OBS - though that would be with some additional changes.

So from an “updating the submodule” point of view I think we are covered.

Also I started to read how come Notification.requestPermission api is always responding “denied” on SFOS browser. I hope it is not because of old tech, but an embedding oversight/limitation (I did test on https). That may take a while (OR could be implemented by injecting a JS polyfill?, but I’d rather not).

However I am not especially good at being constantly focused at one thing. So I would like to team up with @pherjung and do this together in an org repo (so not a personal fork) like, say, github.com/sailfishos-open.
This model of “adopting” an original author development by a team has worked before.

Thoughts?

3 Likes
#9

Yes you can. We have done it in the past for a few apps.

3 Likes
#10

The OBS build above doesn’t yet work, probably the submodule is not updating, well get back to you…

1 Like
#11

So one nodejs18 && yarn build later… it should work (test build repo here).

(if you broke hydrogen with the previous broken build that I sent, you might want to remove ~/.cache/org.github.thigg.harbour-hydrogen/hydrogen/.mozilla/ and ~/.local/share/harbour-hydrogen - sorry about that )

Some thoughts:

  • It still required to package the yarn cache - so it is not fully open build, though a verifiable one. Not that accessing npm repos at build time would make it any better - it would have required packaging node packages for each one of the dependencies, which is beyond the scope of building harbour-hydrogen.
  • The easier route would be to just build hydrogen-web on github or any CI with access to node commands and npm repository and add Source1=https://path-to-github-build such as github.com/vector-im/hydrogen-web/releases/tag/v0.3.7 instead of using a submodule
    (of course this is in hindsight)
4 Likes
#12

I downloaded the build from the testrepo and it is running fine for me. Couldnt test calls yet however, that would be interesting…

#13

hydrogen had another release which brings experimental cross signing between devices :slight_smile:

1 Like
#14

Thanks for testing the OBS build thigg:)
Did you have any of the abive mentioned folders?

I think we need to change the build route to the simpler one to not involve nodejs maybe.

#15

I didnt use the previous build and it wasnt broken :wink:

1 Like
#16

Should we go ahead and prepare a release, or do you want to update hydrogen to the most current version first?

#17

There is a small bug once the app has been updated. It’s necessary to clear the cache to get a working application. Currently I haven’t found a way to include these steps in the package.

#18

easiest way is probably to do this in the qml file. write the version to storage/config, if it changed, clear the cache before starting the server.

Do you know why the cache needs to be cleared? I would have expected that hydrogen handles this.

#19

Unfortunately, it’s beyond my knowledge.

#20

We have few data points: me and @pherjung needing to clear the cache possibly because of the first OBS build gone wrong, Me with the initial sfdk build not needing to clear the cache. @thigg with the good OBS build not needeing to clear the cache. And lastly, @pherjung retracing the steps (install store version install good OBS build) which resulted in needing the cache clear, am I correct?

#21

@pherjung are you 100% sure that clearing the cache is needed? I just got confirmation from @direc85 that it worked directly for him too.

@thigg I would do the next hydrogen version update when I have time to refactor the OBS build a bit.
BTW, would you agree to move your repo to https://github.com/sailfishos-open/harbour-hydrogen to keep a redirect and the current issues?
Thanks!

#22

I did have a hiccup with one channel, but I think it has something to do with changes in the channel. It was moved to its own space (or something like that, it’s a Matrix thing) and for a day I couldn’t see any messages in the channel. When I sent a message to the channel using another client, it was restored to normal functionality.

So no clearing caches required in my case :slight_smile:

1 Like